Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No close button on an individual tab #40

Closed
johanbrook opened this issue Jul 4, 2016 · 8 comments
Closed

No close button on an individual tab #40

johanbrook opened this issue Jul 4, 2016 · 8 comments
Labels
help wanted Contributions wanted towards the issue

Comments

@johanbrook
Copy link
Contributor

johanbrook commented Jul 4, 2016 •
edited

It's only possible to close a tab by hitting cmd+w, which perhaps shouldn't be the only way of closing a tab.

Version: 0.2.1

(I'm filing a bunch of UI stuff now, to keep track of them. Can be triaged).
@rauchg
Copy link
Member

rauchg commented Jul 4, 2016

@johanbrook spot on. I was thinking of a little thin x only shown on tab hover:

screen shot 2016-07-04 at 4 09 06 pm

screen shot 2016-07-04 at 4 10 06 pm

The SVG: x-icon.svg.zip
Let me know if this makes sense or is too subtle.

@rauchg
Copy link
Member

rauchg commented Jul 4, 2016

By the way, I would like the x to fade in.

@johanbrook
Copy link
Contributor Author

johanbrook commented Jul 4, 2016 •
edited

Totally, that looks nice! Basically like Chrome's close icons' behaviour and appearance. 

I can give this ago if you wanna, unless you're already at it and can add it way faster than I can :)

@rauchg
Copy link
Member

rauchg commented Jul 5, 2016

@johanbrook by all means own this one, and let me know if you have any questions

@rauchg
Copy link
Member

rauchg commented Jul 5, 2016

thank you!

@dbkaplun
Copy link

dbkaplun commented Jul 5, 2016

+1 let me know if you need any help @johanbrook

@johanbrook johanbrook mentioned this issue Jul 5, 2016
Closed
johanbrook added a commit to johanbrook/hyperterm that referenced this issue Jul 5, 2016
@johanbrook
Add button for closing a tab (re: vercel#40)
3e6da7e
@johanbrook johanbrook mentioned this issue Jul 5, 2016
Merged
rauchg pushed a commit that referenced this issue Jul 6, 2016
@johanbrook @rauchg
Add close cross for tabs (#58)
bfefc2d 
* Add .DS_Store to gitignore

* Add SVG icon component

* Add button for closing a tab (re: #40)

* Use external icon sheet for icons
@jacobmischka
Copy link

I'm just reading through issues, should this be closed since #58 was merged?

@Qard
Copy link

Qard commented Jul 19, 2016

Looks like it, yes.

@timothyis timothyis added help wanted Contributions wanted towards the issue and removed contribution-wanted labels Jul 26, 2016
@karlhorky karlhorky mentioned this issue Sep 19, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Contributions wanted towards the issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@rauchg @Qard @johanbrook @timothyis @dbkaplun @jacobmischka