Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text deselect #1218

Merged
merged 1 commit into from Dec 15, 2016
Merged

Fix text deselect #1218

merged 1 commit into from Dec 15, 2016

Conversation

ppot
Copy link
Contributor

@ppot ppot commented Dec 15, 2016

Close #819

@ppot
Copy link
Contributor Author

ppot commented Dec 15, 2016

I can't review myself. @matheuss @albinekb @rauchg

@ppot ppot mentioned this pull request Dec 15, 2016
2 tasks
Copy link
Contributor

@albinekb albinekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Havn't tested this myself, but the code looks 🆗

@naturalethic
Copy link

naturalethic commented Dec 20, 2016

This is still not fixed on MacOS at least. First of all, e.code is ShiftLeft, ControlLeft, etc. But even if I hack it to check these, and ensure that selection.clear is not being called, the selection is still being cleared by something else.

In case anyone is interested I changed the test to:
if (!/^(Shift|Control|CapsLock)/.test(e.code) && e.key !== 'Dead') {

@ppot
Copy link
Contributor Author

ppot commented Dec 20, 2016

On MacOS this work perfectly. This is not released yet. If you still have a problem. feel free to make a gif. With your specific use case.

@naturalethic
Copy link

I was hacking on it in dev mode using the repo master branch. A production build to dist doesn't work for me, it won't open a new window. Anyhoo, I'm fine waiting for the next official release. Thanks again.

@@ -213,20 +213,22 @@ hterm.Keyboard.prototype.onKeyDown_ = function (e) {

if (e.altKey || e.metaKey || isAccelerator(e)) {
// hterm shouldn't consume a hyper accelerator
// // Was the hyperCaret removed for selectAll
if (e.key === 'v' && !this.terminal.cursorNode_.contains(this.hyperCaret)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ppot why this is here? 🤔

@yliaho
Copy link

yliaho commented Mar 7, 2017

spans that have white background color are still obfuscated... I had to google this issue, sorry if this isn't the right place to moan about this.

This fixes all of the white-against-white issues:

termCSS: 'span[style*="background-color: rgb(255, 255, 255);"] {color: black!important;}'

tylerong pushed a commit to tylerong/hyper that referenced this pull request Jul 3, 2017
@brian-slate
Copy link

brian-slate commented May 2, 2018

This fixes all of the white-against-white issues:
termCSS: 'span[style*="background-color: rgb(255, 255, 255);"] {color: black!important;}'

with backgroundColor: 'rgba(0,0,0,0.6)' I'm still seeing white on white, even with the termCSS setting above.

@ppot
Copy link
Contributor Author

ppot commented May 4, 2018

If you have issue. We recommend creating new one and linking it to the closed one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants