Reducer specs #150
Reducer specs #150
Conversation
| "eslint-config-standard": "5.3.1", | ||
| "eslint-plugin-promise": "1.3.2", | ||
| "eslint-plugin-react": "5.2.2", | ||
| "eslint-plugin-standard": "1.3.2", | ||
| "mocha": "^2.5.3", |
There was a problem hiding this comment.
I prefer ava these days:
https://github.com/avajs/ava
There was a problem hiding this comment.
sweet! gonna take a look at it
|
Looks awesome so far. Thank you for taking on such an important thing. |
|
@rauchg I think we're all set with reducer specs. From now on, I intend to write tests to other things as well. |
| @@ -22,17 +22,22 @@ | |||
| "seamless-immutable": "6.1.1" | |||
| }, | |||
| "devDependencies": { | |||
| "ava": "^0.15.2", | |||
| "ava-spec": "^1.0.1", | |||
There was a problem hiding this comment.
Can you please pin deps? Thank you!
|
Pinging @sindresorhus in case you wanna give the ava-ness of this a look :D |
|
Generally looks good, although I'm personally not a big fan of all the
Feels moot adding |
|
@diogobeda there are some merge conflicts. |
|
Sorry, I've been very busy these days. Only gonna be able to look into it on the weekend. |
timothyis
added
the
👩🔬 Status: In Progress
matheuss
removed
the
👩🔬 Status: In Progress
|
Reducer tests would be immensely useful, and would be really good for confirming the behaviour of stuff like #693. @diogobeda: if you don't think you'll have time during the next weeks I can rebase and finish this up for you, let me know. Looks like a really clean implementation (although I agree that the |
|
Oh, the irony! I didn't have time to finish this cause I'm working on a talk I'm giving this month about testing redux. Sorry to leave it like this, guys. |
|
Don't worry @diogobeda!! Whenever you, @ekmartin or someone else have time to work on this, a reopen/new PR is more than welcome 😄 |
Hi there, I wanted to write some tests for the app and I wanted to start by the reducers. On this first commit, I only configured the tests environment/command and wrote a sample spec so you can give your opinions on both. After we agree on a standard, I'll write the rest of the tests using them.
What do you think?
cc @rauchg