Making it explicit that opacity is only supported in macOS #2463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chabou
reviewed
Nov 16, 2017
| @@ -27,6 +27,7 @@ module.exports = { | |||
| foregroundColor: '#fff', | |||
|
|
|||
| // terminal background color | |||
| // opacity is only supported on macOS | |||
There was a problem hiding this comment.
Maybe transparency is better. Or Changing opacity...
There was a problem hiding this comment.
I think this is good, it's called opacity everywhere i css.
albinekb
approved these changes
Nov 16, 2017
|
Thank you @AndreFCruz for this first contribution! 🙏 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR is ready to be merged.
Makes it more explicit that background colour opacity is not supported in windows/linux.
Related to #2451