Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AVA tests and made them mandatory. #2705

Merged
merged 1 commit into from
Feb 24, 2018
Merged

Conversation

Ameya05
Copy link
Contributor

@Ameya05 Ameya05 commented Feb 24, 2018

Removed obsolete test cases and included unit tests a mandatory step while build and push.

Fixed #2703

…sts as mandatory step while build and push
Copy link
Contributor

@albinekb albinekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looks like the functions tested are long gone :)

@chabou chabou added the 👨‍🎓 Hackillinois PR achieved during Hackillinois label Feb 24, 2018
@chabou
Copy link
Collaborator

chabou commented Feb 24, 2018

Best thing is tests are now mandatory and I'll never brake them again :trollface:

@chabou
Copy link
Collaborator

chabou commented Feb 24, 2018

@Ameya05 Thank you a lot for this PR 🙏

@chabou chabou merged commit 76beaa3 into vercel:canary Feb 24, 2018
@Xapphire13
Copy link
Contributor

@chabou, these changes have existed in this pr #2459 for 3 months now...

@chabou
Copy link
Collaborator

chabou commented Feb 27, 2018

@Xapphire13 Sorry for that. But restoring test what not your PR main goal.
I can't merge your PR without hardcore reviewing/testing it.
But I could merge this one.

Keep in mind that is always better to have little PR that address only one issue.

But I feel really sorry to have your PR unreviewed since 3 months... 😞

@Xapphire13
Copy link
Contributor

@chabou
I understand that. My issue is that you stopped replying to all correspondence on the pull request entirely (from me and other members of the community). As for testing, it's a very small change (with UTs) that should be easy to test in a short period of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👨‍🎓 Hackillinois PR achieved during Hackillinois
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants