Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent build job when releasing #2787

Merged
merged 1 commit into from
Mar 26, 2018
Merged

Prevent build job when releasing #2787

merged 1 commit into from
Mar 26, 2018

Conversation

chabou
Copy link
Collaborator

@chabou chabou commented Mar 26, 2018

Running build job on tags because release job will do the same

@chabou chabou requested a review from timothyis March 26, 2018 21:59
@chabou chabou changed the title Prevent build when releasing Prevent build job when releasing Mar 26, 2018
timothyis
timothyis approved these changes Mar 26, 2018
View reviewed changes
Copy link
Contributor

@timothyis timothyis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Perhaps we'd want artifacts at some point on the release job (since we're not running the build job with artifact store now), but we can sort that later

@chabou
Copy link
Collaborator Author

chabou commented Mar 26, 2018

I think we don't need these artefact because they are automatically uploaded to Github Release

@chabou chabou merged commit e181e1e into vercel:canary Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothyis timothyis timothyis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chabou @timothyis