always set js to lf #2795
Merged
always set js to lf #2795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocally and this can make lint fail
|
This will corrupt images, as you're now saying that Git should convert all files to What you want is: I wish Git supported a way to say "make all text files LF"… |
|
Oh thanks! |
albinekb
approved these changes
Apr 3, 2018
chabou
approved these changes
Apr 5, 2018
chabou
pushed a commit
that referenced
this pull request
Dec 15, 2018
always set text to lf, if on auto, Windows will change them to crlf locally and this can make lint fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if on auto, Windows will change them to crlf locally and this can make lint fail
@paulcbetts thoughts?