Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust clickable region of control buttons #3017

Merged
merged 1 commit into from
May 23, 2018
Merged

Adjust clickable region of control buttons #3017

merged 1 commit into from
May 23, 2018

Conversation

lujjjh
Copy link
Contributor

@lujjjh lujjjh commented May 14, 2018

On Windows, the close button (rather than the border) is expected to be hit when someone clicks the top-right corner of the screen if a window is maximized.

Make the control buttons easier to click on Windows when Hyper is maximized.
@albinekb albinekb requested a review from timothyis May 14, 2018 15:47
@Stanzilla
Copy link
Collaborator

I don't quite understand, when I click on the top right corner I hit close all the time?

@Stanzilla Stanzilla added 👀 Awaiting Response Issue or PR is awaiting a response from the author 🎨 Type: Enhancement Issue or PR is an enhancement request/proposal for Hyper labels May 16, 2018
@lujjjh
Copy link
Contributor Author

lujjjh commented May 16, 2018

@Stanzilla If the window is maximized, yes.

Here is an example in User Interface Principles (intuitiveness):

In one of the early Windows Vista preview builds, the Minimize, Maximize, and Close buttons of any window became different. In previous versions of Windows (especially when using a single monitor), you develop a habit of moving the cursor in the top-right corner of the screen and clicking. This always resulted in the window closing. Now in this particular build of Windows Vista, there were approximately 8 pixels worth of space between the Close button and the right-most border of the window. The extra space did make it look cool (and was probably necessary for the cool glow animation the button sported), but was irritating because it did not allow users to close open windows as easily. Reconditioning your mind can be tough. Thankfully, in the following build, this issue was addressed. Now, there still is space between the border of the window and the close button, but clicking that space also causes the window to be closed.

@Stanzilla
Copy link
Collaborator

Well you said is expected to be hit when someone clicks the top-right corner of the screen if a window is maximized. and that is exactly what is happening here?

@lujjjh
Copy link
Contributor Author

lujjjh commented May 16, 2018

There is actually a 1-pixel border on the top so I hit the border if I click exactly the top-right corner. I have to move the cursor down and click the close button.

That is why I move .header_windowControls 1 pixel higher, which makes it easier to close the window.

@Stanzilla
Copy link
Collaborator

Alright, fine by me :)

@Stanzilla Stanzilla removed the 👀 Awaiting Response Issue or PR is awaiting a response from the author label May 16, 2018
@chabou chabou merged commit 16f163d into vercel:canary May 23, 2018
@chabou
Copy link
Collaborator

chabou commented May 23, 2018

@lujjjh Thank you for your help

@lujjjh lujjjh deleted the patch-1 branch May 25, 2018 15:50
chabou pushed a commit that referenced this pull request Dec 15, 2018
On Windows, the close button (rather than the border) is expected to be hit when someone clicks the top-right corner of the screen if a window is maximized.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 Type: Enhancement Issue or PR is an enhancement request/proposal for Hyper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants