Replace node-fetch with electron-fetch #3108
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user starts
hyper
, it sends the request tohttps://hyper-news.now.sh
from notifications.js file. If the user is behind the proxy server, this request is going to fail, because in this case, we have to find(another scenario from Linux auto update)
This pull request replace node-fetch with electron-fetch.
The
electron-fetch
repeats API fromnode-fetch
(it was forked from last one), but it's using Electron net module, sohyper
don't need to care about proxy configuration.The
net
module provides