Windows Keybindings was not correctly setup #3146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dslatkin
reviewed
Sep 10, 2018
There was a problem hiding this comment.
Would like to see this fixed - but having trouble seeing how this doesn't break https://github.com/zeit/hyper/blob/6451ba7f85fe5b88268cf4e57da8a1a13f6046b7/app/config/import.js#L29 since in that file, defaultPlatformKeyPath is called as a function but in this pull request it's defined as a string?
|
Commented more on the issue here regarding this fix in the context of the central issue at hand. |
|
@hknielsen willing to pick this up again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created #3025 because on Windows, using Powershell as shell, key's didnt work for fx. move word.
What I saw was, "alt+arrows" worked to some degree, but not the expected keymappings defined in
win32.json.So for some reason the beneath didnt work, and if evaluated directly in Paths.js it did. Dont know enough of nodejs to say what are happening. But this fixed it. Could be a Windows specific NodeJs bug.
If you got any better way of doing this let me know.