Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for config.session being ignored #3367

Merged
merged 1 commit into from Dec 26, 2018
Merged

Conversation

juancampa
Copy link
Contributor

@juancampa juancampa commented Dec 25, 2018

Problem

config.session was being ignored after #3352

Solution

Don't ignore config.session and pass it to node-pty.

Diff looks a bit noisy because I renamed some variables and now I'm returning options instead of uid from create session

Tests

  • Initial sessions use the right shell
  • subsequent sessions use the right shell

@juancampa juancampa mentioned this pull request Dec 25, 2018
19 tasks
@Stanzilla
Copy link
Collaborator

Can confirm this unbreaks the shell feature on Windows.

@rauchg rauchg merged commit cba4c66 into vercel:canary Dec 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants