Emoji Fix #3388
Merged
Emoji Fix #3388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My understanding is that this was needed at some point because we weren't typing into a textarea. No that we're typing into a textarea the browser (i.e. Chromium) handles this for us
chabou
approved these changes
Jan 4, 2019
| @@ -45,7 +45,6 @@ | |||
| "editor:deleteBeginningLine": "command+backspace", | |||
| "editor:deleteEndLine": "command+delete", | |||
| "editor:clearBuffer": "command+k", | |||
| "editor:emojis": "command+ctrl+space", | |||
rauchg
approved these changes
Jan 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
cmd+ctrl+space didn't show the emoji dialog
Solution
Stop intercepting this keymapping and let the browser handle it. This makes sense now that we're always using a
textareaas our source of inputNOTE: The rest of the changes to make emoji work are on this PR: vercel/xterm.js#6