Update copyright year in Help->About Hyper #3415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know if this is necessary or not as it's not for the license(from vercel#2566). Still mentioning it since I noticed it.
Stanzilla
approved these changes
Jan 21, 2019
|
Thanks! |
oguzzkilic
reviewed
Apr 17, 2019
app/menus/menu.js
Outdated
| @@ -42,7 +42,7 @@ exports.createMenu = (createWindow, getLoadedPluginVersions) => { | |||
| dialog.showMessageBox({ | |||
| title: `About ${appName}`, | |||
| message: `${appName} ${appVersion} (${updateChannel})`, | |||
| detail: `Plugins: ${pluginList}\n\nCreated by Guillermo Rauch\nCopyright © 2018 ZEIT, Inc.`, | |||
| detail: `Plugins: ${pluginList}\n\nCreated by Guillermo Rauch\nCopyright © 2019 ZEIT, Inc.`, | |||
There was a problem hiding this comment.
permanent solution;
date = new Date()
date.getFullYear()
There was a problem hiding this comment.
Just do new Date().getFullYear()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if this is necessary or not as it's not for the license(from #2566).
Still mentioning it since I noticed it.