Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shortcut for opening hamburger menu (Windows) #3444

Merged
merged 2 commits into from
Mar 31, 2019
Merged

Add shortcut for opening hamburger menu (Windows) #3444

merged 2 commits into from
Mar 31, 2019

Conversation

doniyor2109
Copy link
Contributor

Opens hamburger menu for alt shortcut on Windows.

PR for #3443.

chabou
chabou suggested changes Jan 26, 2019
View reviewed changes
Copy link
Collaborator

@chabou chabou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your help 🙏

I think that opening hamburger menu should be conditioned by showHamburgerMenu config.

Keymap should be added to other platforms too. But I don't know which key is relevant.

@Stanzilla Stanzilla merged commit 81ff38c into vercel:canary Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stanzilla Stanzilla Stanzilla approved these changes

@chabou chabou Awaiting requested review from chabou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@doniyor2109 @Stanzilla @chabou