Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping electron to 3.1.3 #3458

Merged
merged 1 commit into from Feb 5, 2019
Merged

Conversation

juancampa
Copy link
Contributor

@juancampa juancampa commented Feb 4, 2019

This version includes a vulnerability fix but also broke our copy mechanism due to this change. Adding registerAccelerator: true seems to fix it on Linux.

  • Linux
  • MacOS
  • Windows

@juancampa
Copy link
Contributor Author

MacOS seems to also work. Can't test on Windows right now but it should be fine

@juancampa juancampa requested a review from chabou February 4, 2019 17:43
@juancampa juancampa added the ❣️ Priority: High Issue is of High priority label Feb 4, 2019
@juancampa juancampa merged commit bb1f94e into vercel:canary Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❣️ Priority: High Issue is of High priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant