Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose active window positon on move to reducer #3470

Merged
merged 3 commits into from
Feb 26, 2019

Conversation

ppot
Copy link
Contributor

@ppot ppot commented Feb 10, 2019

Expose window position {x, y} once the active window when it's moved.

In order to add modularity for plugins:

  • The onWindow only expose the window creation. But once the window is created, moved action are not accessible.
  • Allow plugins to know the current position of the active window based on the UI_WINDOW_MOVE from the window move action lunched by the RPC.
  • Enable better state recording for plugins such as session restoration

app/ui/window.js Outdated Show resolved Hide resolved
app/rpc.js Outdated Show resolved Hide resolved
app/ui/window.js Outdated Show resolved Hide resolved
@juancampa
Copy link
Contributor

@chabou does this LGTM now?

@chabou
Copy link
Collaborator

chabou commented Feb 26, 2019

Thank you for your help @ppot

@chabou chabou merged commit 1747c57 into vercel:canary Feb 26, 2019
@ppot ppot deleted the f/window/actions branch March 2, 2019 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants