Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3542: x coordinate maps to col, and y coordinate maps to row #3547

Merged
merged 1 commit into from
Mar 27, 2019
Merged

Fixes #3542: x coordinate maps to col, and y coordinate maps to row #3547

merged 1 commit into from
Mar 27, 2019

Conversation

ArtBIT
Copy link
Contributor

@ArtBIT ArtBIT commented Mar 27, 2019

cols and rows properties of the CursorFrame object were swapped. x coordinate should be mapped to col and y coordinate to row.
Rows and columns

chabou
chabou approved these changes Mar 27, 2019
View reviewed changes
Copy link
Collaborator

@chabou chabou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@chabou
Copy link
Collaborator

chabou commented Mar 27, 2019

This is a breaking change but if anybody used it, it would have noticed this bug.

@chabou chabou merged commit 72bc73e into vercel:canary Mar 27, 2019
@chabou
Copy link
Collaborator

chabou commented Mar 27, 2019

@ArtBIT Thank you for your help 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chabou chabou chabou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ArtBIT @chabou