Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use configured shell to update plugins #447

Merged
merged 3 commits into from
Jul 30, 2016
Merged

Use configured shell to update plugins #447

merged 3 commits into from
Jul 30, 2016

Conversation

albinekb
Copy link
Contributor

@albinekb albinekb commented Jul 27, 2016

Request to do so in #440
However, this requires the user to have npm installed (#381) ...
Based on sindresorhus/shell-env#3

@albinekb
Copy link
Contributor Author

@mike-engel Could you test if this works for your setup? 👼

@mike-engel
Copy link
Contributor

Just tested again. Nice work! 👍

@leo
Copy link
Contributor

leo commented Jul 28, 2016

We should wait until sindresorhus/shell-env#3 was merged. Because loading something directly from a GitHub branch is way too risky!

@timothyis timothyis added the 🙅‍♀️ Status: On Hold Issue or PR is on hold label Jul 29, 2016
@sindresorhus
Copy link
Contributor

shell-env@0.2.0 with ability to specify shell is out.

@albinekb
Copy link
Contributor Author

Thanks @sindresorhus ❤️

@albinekb albinekb changed the title [WIP] Use configured shell to update plugins Use configured shell to update plugins Jul 30, 2016
@albinekb
Copy link
Contributor Author

Pingeling @leo @rauchg have a look 🦄

@leo
Copy link
Contributor

leo commented Jul 30, 2016

Thank you all for your patience and the changes made! 😘

@leo leo merged commit 3198a90 into vercel:master Jul 30, 2016
@timothyis timothyis added Status: Accepted and removed 🙅‍♀️ Status: On Hold Issue or PR is on hold labels Aug 29, 2016
@timothyis timothyis added this to the v0.8.0 milestone Aug 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants