redirect exec calls from renderer to main process #5803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there, |
2 tasks
LabhanshAgrawal
force-pushed
the
child_process2
branch
from
50cd4bb
to
f313262
Compare
|
Hi there, |
LabhanshAgrawal
force-pushed
the
child_process2
branch
from
f313262
to
b11d361
Compare
|
Hi there, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downgrading to electron 11 might not be feasible, to fix the performance issues, as the issue will still be there in signed build.
Instead, we can provide a shim for
child_processthat will send the command to main process and get the result from there over IPC. Performance with this should be good enough as the perf bug has lesser impact on main process (electron/electron#26143 (comment))