-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed unreliable hot reloading #29
Conversation
tungv
commented
Aug 25, 2017
- remove cwd option to yield absolute paths
- add debounce to avoid multiple restarts happen unexpectedly when more than one file change
1. remove cwd option to yield absolute paths 2. add debounce to avoid multiple restarts happen unexpectedly when more than one file change
Looks really good! But how about using a package for the debouncing? The function looks like it could be abstracted away with a package. |
I initially used lodash, but worried about the size of the package. What do you think about lodash/debounce? |
@tungv I'd rather go with a package that's only doing debouncing, nothing else. |
Ok Leo, I will update in a few hours. Thanks! |
hi @leo, I opted to use their code looks very clean https://unpkg.com/debounce@1.0.2 |
Thanks a lot! |
Great. Thank you for merging this over the weekend. I'm eager to use the new version next week. |
It seems like this merge makes the --ignore option no longer work properly, reverting #24 |
it's true. |
That requires detecting if a pattern is resolvable. Patterns like |
maybe we should explicitly say that ignore pattern are not relative to cwd. |
Interestingly, this doesn't fix hot reloading issue for me. Still same thing as described in #23 :/ |