Suppress console errors on testing

[cyberwombat]

Could it be possible to not dump errors to console while in test env? It makes a total mess of tests. I have to compose all my handlers with a try/catch to swallow the dump. My error is tested through AVA throws but my screen gets filled with production error dumps.

[cyberwombat]

Something like:

const sendError = (req, res, errorObj) => {
  const statusCode = errorObj.statusCode || errorObj.status
  const message = statusCode ? errorObj.message : 'Internal Server Error'
  send(res, statusCode || 500, DEV ? errorObj.stack : message)
  if (process.env.NODE_ENV === 'test') return
  if (errorObj instanceof Error) {
    console.error(errorObj.stack)
  } else {
    console.warn('thrown error must be an instance Error')
  }
}

[lfades]

@leo Can this be a implemented ? Ignoring the logs is great when you're running tests that should throw, if any other test throws the test runner will tell you that so no need to log for errors, the only downside I can see is if the error thrown by the test runner is being cached (by a try/catch - catch()) you will notice anything, but that's just a bad practice that will break the entire test

there was an implementation for it before: #124

[vespertilian]

Another suggested implementation.

If you provide console as an input defaulted to the native console command, we can override it when testing. I plan just to use my own version of sendError for the time being, however it would be nice if this came out of the box with Micro. Also useful if you want to pass in a custom logger.

Current implemenation

const sendError = (req, res, errorObj) => {
	const statusCode = errorObj.statusCode || errorObj.status;
	const message = statusCode ? errorObj.message : 'Internal Server Error';
	send(res, statusCode || 500, DEV ? errorObj.stack : message);
	if (errorObj instanceof Error) {
		console.error(errorObj.stack);
	} else {
		console.warn('thrown error must be an instance Error');
	}
};

Suggested implementation

const sendError = (req, res, errorObj, _console=console) => {
	const statusCode = errorObj.statusCode || errorObj.status;
	const message = statusCode ? errorObj.message : 'Internal Server Error';
	send(res, statusCode || 500, DEV ? errorObj.stack : message);
	if (errorObj instanceof Error) {
		_console.error(errorObj.stack);
	} else {
		_console.warn('thrown error must be an instance Error');
	}
};

No breaking changes. Happy to pull request this if you will accept it.

[mcchrish]

Any updates on this? I thought #124 fixed it but still gets errors being logged when the default error handler is used.

[timneutkens]

Check this comment: #349 (comment)

[timneutkens]

Going to close this in favor of #369

[lucasconstantino]

@cyberwombat this is a common issue across testing in general. I've build a tool for that some time ago: https://github.com/lucasconstantino/console-suppress