Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing type declarations in conditional exports #191

Merged
merged 1 commit into from
Jun 16, 2023
Merged

fix: add missing type declarations in conditional exports #191

merged 1 commit into from
Jun 16, 2023

Conversation

khmm12
Copy link
Contributor

@khmm12 khmm12 commented Aug 23, 2022

Types should be present in conditional exports. TypeScript with configured module resolution NodeNext doesn't look back to package.types field.

@khmm12
fix: add missing type declarations in conditional exports
70558ff 
Types should be present in conditional exports. TypeScript with configured module resolution `NodeNext` doesn't look back to `package.types` field.
mrmckeb
mrmckeb approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@mrmckeb mrmckeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just about to do this myself, thank you!

@mrmckeb mrmckeb merged commit dfd1803 into vercel:master Jun 16, 2023
@jimmy-guzman jimmy-guzman mentioned this pull request Oct 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrmckeb mrmckeb mrmckeb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@khmm12 @mrmckeb