Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails to compile when tsconfig has incremental: true #606

Closed
Gozala opened this issue Oct 19, 2020 · 4 comments · Fixed by #674
Closed

Fails to compile when tsconfig has incremental: true #606

Gozala opened this issue Oct 19, 2020 · 4 comments · Fixed by #674
Labels
bug Something isn't working

Comments

@Gozala
Copy link

Gozala commented Oct 19, 2020

Output:

ncc build src/index.ts
ncc: Version 0.24.1
ncc: Compiling file index.js
ncc: Using typescript@4.0.3 (local user-provided)
Error: [tsl] ERROR
      TS5074: Option '--incremental' can only be specified using tsconfig, emitting to single file or when option `--tsBuildInfoFile` is specified.
    at /Users/gozala/.config/yarn/global/node_modules/@vercel/ncc/dist/ncc/index.js.cache.js:1:3198784
    at /Users/gozala/.config/yarn/global/node_modules/@vercel/ncc/dist/ncc/index.js.cache.js:1:2305642
    at eval (eval at create (/Users/gozala/.config/yarn/global/node_modules/@vercel/ncc/dist/ncc/index.js.cache.js:1:1291515), <anonymous>:11:1)

Reproducible on the following tree https://github.com/Gozala/typescript-error-reporter-action/tree/a103de6e96e3797e40b455e878b25e8cf3a8b2d1
Gozala added a commit to Gozala/typescript-error-reporter-action that referenced this issue Oct 19, 2020
@Gozala
chore: disable incremental builds to workaround vercel/ncc#606
227d951
Gozala added a commit to Gozala/typescript-error-reporter-action that referenced this issue Oct 19, 2020
@Gozala
chore: disable incremental builds to workaround vercel/ncc#606
6a49b5d
@BoBoooooo
Copy link

the same question ..

@mforman1
Copy link

Getting the same error, any suggestion?

@styfle styfle added the bug Something isn't working label Mar 22, 2021
@styfle
Copy link
Member

styfle commented Mar 22, 2021

Confirmed, this is a bug.

Since ncc has its own cache, we can probably ignore the incremental option from tsconfig.json.

Feel free to submit a PR and we'll take a look, thanks!

@Gozala
Copy link
Author

Gozala commented Mar 22, 2021

Since ncc has its own cache, we can probably ignore the incremental option from tsconfig.json.

Incremental option is used to compile TS linked reference so I'm not sure bcc cache would necessarily apply.

@huozhi huozhi mentioned this issue Mar 23, 2021
Merged
styfle added a commit that referenced this issue Apr 5, 2021
@huozhi @styfle
enhance: upgrade local ts (#674)
6f4714d 
Fixes #606

* bump ts-loader version
* bump built-in ts version
* override `incremental` option to `false`

Co-authored-by: Steven <steven@ceriously.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enhance: upgrade local ts
4 participants
@Gozala @styfle @BoBoooooo @mforman1