Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset directory emission, test refactoring #106

Merged
merged 1 commit into from
Dec 4, 2018
Merged

Conversation

guybedford
Copy link
Contributor

Fixes #68.

This extends asset emission to direct emission of directories, fixing the strong-globalize test case.

I also went ahead and refactored the tests to use the "run" approach over an embedded eval. This simplifies the source maps handling but did require rewriting out the module.exports execution. Top-level promises work out here fine though since as a separate process, each test runs to completion.

This does not close #58 as it is effectively just the first step of that.

@codecov-io
Copy link

Codecov Report

Merging #106 into master will increase coverage by 1.75%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
+ Coverage   73.31%   75.06%   +1.75%     
==========================================
  Files           6        6              
  Lines         356      385      +29     
==========================================
+ Hits          261      289      +28     
- Misses         95       96       +1
Impacted Files Coverage Δ
src/index.js 93.33% <100%> (+1.8%) ⬆️
src/loaders/relocate-loader.js 92.6% <93.54%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38dd21e...b59d672. Read the comment docs.

@rauchg rauchg merged commit 56aa74d into master Dec 4, 2018
@rauchg rauchg deleted the strong-globalize branch December 4, 2018 19:12
@gijo-varghese
Copy link

@guybedford I'm getting the error with the latest version. I've updated in #68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with strong-globalize Asset wildcards and directory emission
4 participants