-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Slack Integration Test #591
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this test is currently failing
Looks like the test is passing CI now
@styfle I updated the Slack dependency for this test case and while the test started passing here I am still experiencing the error outlined in #590 in my own code bases with the updated Slack SDK and I've recreated the issue with a unit test in https://github.com/ataylorme/ncc-0.24.1-slack-compilation-issue that actually uses the SDK, not just imports at as this test does. |
The branch you're testing against here is newer than 0.24.1. I tried with the latest ncc and it worked. So I'll go ahead and release a new version, thanks 👍 |
Okay, awesome, thank you @styfle. Once a new version of edit: version |
Note: this test is currently failing. See #590
Perhaps this pull request to add a test can be used for test driven development to resolve the issue.