Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Slack Integration Test #591

Merged
merged 6 commits into from
Nov 5, 2020
Merged

Add Slack Integration Test #591

merged 6 commits into from
Nov 5, 2020

Conversation

ataylorme
Copy link
Contributor

Note: this test is currently failing. See #590

Perhaps this pull request to add a test can be used for test driven development to resolve the issue.

@styfle styfle linked an issue Oct 13, 2020 that may be closed by this pull request
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test is currently failing

Looks like the test is passing CI now

@ataylorme
Copy link
Contributor Author

Looks like the test is passing CI now

@styfle I updated the Slack dependency for this test case and while the test started passing here I am still experiencing the error outlined in #590 in my own code bases with the updated Slack SDK and ncc version 0.24.1. 0.23.0 does not have the issue.

I've recreated the issue with a unit test in https://github.com/ataylorme/ncc-0.24.1-slack-compilation-issue that actually uses the SDK, not just imports at as this test does.

@styfle
Copy link
Member

styfle commented Nov 5, 2020

The branch you're testing against here is newer than 0.24.1.

I tried with the latest ncc and it worked. So I'll go ahead and release a new version, thanks 👍

@styfle styfle merged commit d62d6a5 into vercel:master Nov 5, 2020
@ataylorme
Copy link
Contributor Author

ataylorme commented Nov 5, 2020

Okay, awesome, thank you @styfle. Once a new version of ncc is released I'll test it out. I'm looking forward to being on the latest and greatest!

edit: version 0.25.0 tested well with my more expanded unit test: https://github.com/ataylorme/ncc-0.24.1-slack-compilation-issue/runs/1359957476

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.24.1 TypeScript compilation triggers Slack SDK error
2 participants