Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing the webpack target #614

Merged
merged 2 commits into from
Nov 6, 2020
Merged

Allow passing the webpack target #614

merged 2 commits into from
Nov 6, 2020

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Nov 6, 2020

This is a follow-up to vercel/next.js#18873 to allow us to pass a target of node,es5 to ncc since webpack defaults to using es6 code for node which breaks ie11 compatibility

styfle
styfle approved these changes Nov 6, 2020
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@styfle styfle added automerge Automatically merge PR once checks pass and removed automerge Automatically merge PR once checks pass labels Nov 6, 2020
styfle
styfle reviewed Nov 6, 2020
View reviewed changes
src/cli.js Outdated Show resolved Hide resolved
@ijjk ijjk requested a review from styfle November 6, 2020 16:59
styfle
styfle reviewed Nov 6, 2020
View reviewed changes
src/cli.js Show resolved Hide resolved
@styfle styfle added the automerge Automatically merge PR once checks pass label Nov 6, 2020
@kodiakhq kodiakhq bot merged commit d217238 into master Nov 6, 2020
@kodiakhq kodiakhq bot deleted the target-option branch November 6, 2020 17:11
@ijjk ijjk mentioned this pull request Nov 6, 2020
Merged
@styfle styfle mentioned this pull request Nov 6, 2020
Merged
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Nov 6, 2020
@ijjk
Ensure correct target is used for ncc'ing web-vitals (#18905)
f02f704 
This makes sure we don't use es6 syntax when compiling the `web-vitals` package with `ncc` since that breaks IE11 compatibility 

x-ref: vercel/ncc#614
LuighiV pushed a commit to openpolitica/create-openpolitica-nextjs-app that referenced this pull request May 12, 2021
@ijjk
Ensure correct target is used for ncc'ing web-vitals (#18905)
4b5d575 
This makes sure we don't use es6 syntax when compiling the `web-vitals` package with `ncc` since that breaks IE11 compatibility 

x-ref: vercel/ncc#614
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
automerge Automatically merge PR once checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ijjk @styfle