Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update to webpack@5.36.2 #707

Merged
merged 2 commits into from May 10, 2021
Merged

Conversation

adriencohen
Copy link
Contributor

@adriencohen adriencohen commented May 9, 2021

Moving to the latest release of webpack could solve: #499

The underlying issue in webpack seems to not totally be closed. but I was able to build a package using private class fields

@adriencohen adriencohen requested review from styfle and Timer as code owners May 9, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 9, 2021

Codecov Report

Merging #707 (cb18262) into main (2e3eb15) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #707   +/-   ##
=======================================
  Coverage   73.52%   73.52%           
=======================================
  Files          13       13           
  Lines         476      476           
=======================================
  Hits          350      350           
  Misses        126      126           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e3eb15...cb18262. Read the comment docs.

styfle
styfle approved these changes May 10, 2021
Copy link
Member

@styfle styfle left a comment

Thanks!

@styfle styfle enabled auto-merge (squash) May 10, 2021
@styfle styfle changed the title Update to webpack@5.36.2 fix: Update to webpack@5.36.2 May 10, 2021
@styfle styfle merged commit 02e753f into vercel:main May 10, 2021
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants