Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade ts-loader to fix webpack warning #710

merged 3 commits into from May 25, 2021

fix: upgrade ts-loader to fix webpack warning #710

merged 3 commits into from May 25, 2021


Copy link

@huozhi huozhi commented May 25, 2021

Fixes #704

according to ts-loader changelog, it fixes those warnings in 8.0.5 and 8.0.6

since v9.x.x has breaking changes, upgrade to latest v8.x.x

@huozhi huozhi requested review from styfle and Timer as code owners May 25, 2021
Copy link

codecov-commenter commented May 25, 2021

Codecov Report

Merging #710 (927193d) into main (02e753f) will not change coverage.
The diff coverage is n/a.

Current head 927193d differs from pull request most recent head 680d4af. Consider uploading reports for the commit 680d4af to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #710   +/-   ##
  Coverage   73.52%   73.52%           
  Files          13       13           
  Lines         476      476           
  Hits          350      350           
  Misses        126      126           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02e753f...680d4af. Read the comment docs.

styfle approved these changes May 25, 2021
Copy link

@styfle styfle left a comment


@styfle styfle merged commit 89ac860 into vercel:main May 25, 2021
5 checks passed
@huozhi huozhi deleted the fix-warn branch May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

3 participants