Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use sha instead of deprecated md5 for hash algorithm #868

Merged
merged 2 commits into from Feb 11, 2022

Conversation

shakefu
Copy link
Contributor

@shakefu shakefu commented Feb 4, 2022

OpenSSL deprecates and fully removes "md5" as a hash algorithm. This pull request replaces references to "md5" with "sha".

This should resolve the ERR_OSSL_EVP_UNSUPPORTED errors.

Should theoretically fix #805 but I am unable to get tests to pass locally, which seems unrelated.

@shakefu shakefu requested review from styfle and Timer as code owners Feb 4, 2022
styfle
styfle approved these changes Feb 11, 2022
Copy link
Member

@styfle styfle left a comment

Thanks!

@styfle styfle added the automerge Automatically merge PR once checks pass label Feb 11, 2022
@kodiakhq kodiakhq bot merged commit 7bbe288 into vercel:main Feb 11, 2022
5 checks passed
Copy link

@markoenix markoenix left a comment

'md2' in 221

kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request May 23, 2022
## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`

`yarn dev` failed (exit 1) on Node.js 17 & Node.js 18:

```
ncc_amp_optimizer failed because error:0308010C:digital envelope routines::unsupported
[...]
ncc_next__react_dev_overlay failed because error:0308010C:digital envelope routines::unsupported
```

The issue was reported to `@vercel/ncc` (vercel/ncc#805) and fixed by vercel/ncc#868, and `@vercel/ncc@0.33.2` includes the fix. However, Next.js still uses `@vercel/ncc@0.33.1` in `devDependencies`.

The PR bump `@vercel/ncc` to the latest version (which is 0.33.4).
LuighiV pushed a commit to openpolitica/create-openpolitica-nextjs-app that referenced this pull request Aug 24, 2022
## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`

`yarn dev` failed (exit 1) on Node.js 17 & Node.js 18:

```
ncc_amp_optimizer failed because error:0308010C:digital envelope routines::unsupported
[...]
ncc_next__react_dev_overlay failed because error:0308010C:digital envelope routines::unsupported
```

The issue was reported to `@vercel/ncc` (vercel/ncc#805) and fixed by vercel/ncc#868, and `@vercel/ncc@0.33.2` includes the fix. However, Next.js still uses `@vercel/ncc@0.33.1` in `devDependencies`.

The PR bump `@vercel/ncc` to the latest version (which is 0.33.4).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails with Node.js 17
3 participants