Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace deprecated String.prototype.substr() #894

merged 1 commit into from Mar 23, 2022

chore: replace deprecated String.prototype.substr() #894

merged 1 commit into from Mar 23, 2022


Copy link

@CommanderRoot CommanderRoot commented Mar 19, 2022

String.prototype.substr() is deprecated so we replace it with String.prototype.slice() which works similarily but isn't deprecated.
.substr() probably isn't going away anytime soon but the change is trivial so it doesn't hurt to do it.

.substr() is deprecated so we replace it with .slice() which works similarily but isn't deprecated
Signed-off-by: Tobias Speicher <>
@CommanderRoot CommanderRoot requested review from styfle and Timer as code owners Mar 19, 2022
styfle approved these changes Mar 23, 2022
Copy link

@styfle styfle left a comment


@styfle styfle enabled auto-merge (squash) Mar 23, 2022
@styfle styfle merged commit 326cdf3 into vercel:main Mar 23, 2022
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants