Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused getUser #533

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

2wheeh
Copy link

@2wheeh 2wheeh commented Dec 30, 2023

getUser implementation got moved to @app/lib/data:

However, during the update of auth.ts, somehow getUser got decided to retained in auth.ts (which might be a result of a git conflict or intended to bundle seperatly)

and the one that moved in @app/lib/data was not removed.

  1. getUser in the @app/lib/data is no longer in use.
  2. Chapter 15 describes upon the one in auth.ts

Therefore, shouldn't we remove the unused one left in @app/lib/data unless it was unintentional ?
or we could consider removing the one in auth.ts with updating Chapter 15 mdx (don't forget to update type assertion to generic.)

In any case, one of them should be removed.

Thank you for the amazing course.

Copy link

vercel bot commented Dec 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-learn-starter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2023 7:56am
next-seo-starter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2023 7:56am

Copy link

vercel bot commented Dec 30, 2023

@2wheeh is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant