Skip to content

Commit

Permalink
Update Next.js code owners (#51319)
Browse files Browse the repository at this point in the history
This PR updates `.vercel.approvers` files to fix some validation errors
and to more closely match desired behavior for assigning and notifying
members of the team for reviews that was discussed on an internal Slack
thread.

- Owners files for `.cargo/` and `.config/` are moved to their
respective directories instead of being placed at the root.
- Fixes the `@vercel/next-js` team name (it uses a dash instead of a
period)
- Adds `:notify` to reviewers so that all of the people listed are
notified of the pull request, but only a single person would be
requested as a reviewer.
- `@vercel/web-tooling:optional` was made optional so that they are not
requested for any change to `pnpm-lock.yaml` but still have the ability
to approve PRs that modify it.

---------
  • Loading branch information
mknichel committed Jun 15, 2023
1 parent f9ae5b7 commit 1660fdf
Show file tree
Hide file tree
Showing 6 changed files with 22 additions and 11 deletions.
1 change: 1 addition & 0 deletions .cargo/.vercel.approvers
@@ -0,0 +1 @@
@vercel/web-tooling
1 change: 1 addition & 0 deletions .config/.vercel.approvers
@@ -0,0 +1 @@
nextest.toml @vercel/web-tooling
6 changes: 2 additions & 4 deletions .vercel.approvers
Expand Up @@ -5,14 +5,12 @@
@huozhi
@feedthejim
@leerob:optional
@vercel/next.js:optional
@vercel/next-js:optional

# Tooling & Telemetry
pnpm-lock.yaml @vercel/web-tooling
pnpm-lock.yaml @vercel/web-tooling:optional
Cargo.toml @vercel/web-tooling
Cargo.lock @vercel/web-tooling
/.cargo/config.toml @vercel/web-tooling
/.config/nextest.toml @vercel/web-tooling

# Catch any markdown files outside docs (e.g. examples)
**/*.md @vercel/devex
Expand Down
5 changes: 4 additions & 1 deletion packages/next/src/client/.vercel.approvers
@@ -1 +1,4 @@
**/use-intersection.tsx @timneutkens @ijjk @shuding @styfle
use-intersection.tsx @timneutkens:notify
use-intersection.tsx @ijjk:notify
use-intersection.tsx @shuding:notify
use-intersection.tsx @styfle:notify
12 changes: 10 additions & 2 deletions packages/next/src/server/.vercel.approvers
@@ -1,2 +1,10 @@
**/serve-static.ts @timneutkens @ijjk @shuding @styfle @huozhi
**/config.ts @timneutkens @ijjk @shuding @styfle @huozhi
config.ts @timneutkens:notify
config.ts @ijjk:notify
config.ts @shuding:notify
config.ts @styfle:notify
config.ts @huozhi:notify
serve-static.ts @timneutkens:notify
serve-static.ts @ijjk:notify
serve-static.ts @shuding:notify
serve-static.ts @styfle:notify
serve-static.ts @huozhi:notify
8 changes: 4 additions & 4 deletions packages/next/src/server/lib/squoosh/.vercel.approvers
@@ -1,4 +1,4 @@
@timneutkens
@ijjk
@shuding
@styfle
@timneutkens:notify
@ijjk:notify
@shuding:notify
@styfle:notify

0 comments on commit 1660fdf

Please sign in to comment.