Add test for invalid image

vercel · Oct 15, 2020 · 17cddcb · 17cddcb
1 parent c53aec6
commit 17cddcb
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/packages/next/next-server/server/image-optimizer.ts b/packages/next/next-server/server/image-optimizer.ts
@@ -135,9 +135,8 @@ export async function imageOptimizer(
   const upstreamRes = await fetch(href)
 
   if (!upstreamRes.ok) {
-    server.logError(
-      new Error(`Unexpected status ${upstreamRes.status} from upstream ${href}`)
-    )
+    res.statusCode = upstreamRes.status
+    res.end('"url" parameter is valid but upstream response is invalid')
     return { finished: true }
   }
 

diff --git a/test/integration/image-optimizer/test/index.test.js b/test/integration/image-optimizer/test/index.test.js
@@ -218,6 +218,16 @@ function runTests({ w, isDev }) {
     expect(await res.text()).toBe(`"url" parameter is invalid`)
   })
 
+  it('should fail when url fails to load an image', async () => {
+    const url = `http://localhost:${appPort}/not-an-image`
+    const query = { w, url, q: 100 }
+    const res = await fetchViaHTTP(appPort, '/_next/image', query, {})
+    expect(res.status).toBe(404)
+    expect(await res.text()).toBe(
+      `"url" parameter is valid but upstream response is invalid`
+    )
+  })
+
   it('should use cached image file when parameters are the same', async () => {
     await fs.remove(imagesDir)