Consistently Type GS(S)P

vercel · Feb 29, 2020 · 1b3bc5c · 1b3bc5c
1 parent e608c86
commit 1b3bc5c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/packages/next/next-server/server/render.tsx b/packages/next/next-server/server/render.tsx
@@ -471,11 +471,7 @@ export async function renderToHTML(
       // invoke, where we'd have to consider server & serverless.
       const previewData = tryGetPreviewData(req, res, previewProps)
       const data = await getStaticProps!({
-        ...(pageIsDynamic
-          ? {
-              params: query as ParsedUrlQuery,
-            }
-          : { params: undefined }),
+        ...(pageIsDynamic ? { params: query as ParsedUrlQuery } : undefined),
         ...(previewData !== false
           ? { preview: true, previewData: previewData }
           : undefined),
@@ -534,10 +530,10 @@ export async function renderToHTML(
 
   if (getServerSideProps && !isFallback) {
     const data = await getServerSideProps({
-      params,
-      query,
       req,
       res,
+      ...(pageIsDynamic ? { params: params as ParsedUrlQuery } : undefined),
+      query,
     })
 
     const invalidKeys = Object.keys(data).filter(key => key !== 'props')

diff --git a/packages/next/types/index.d.ts b/packages/next/types/index.d.ts
@@ -65,7 +65,7 @@ export {
 }
 
 export type GetStaticProps = (ctx: {
-  params: ParsedUrlQuery | undefined
+  params?: ParsedUrlQuery
   preview?: boolean
   previewData?: any
 }) => Promise<{
@@ -79,9 +79,9 @@ export type GetStaticPaths = () => Promise<{
 }>
 
 export type GetServerSideProps = (context: {
-  params: ParsedUrlQuery | undefined
   req: IncomingMessage
   res: ServerResponse
+  params?: ParsedUrlQuery
   query: ParsedUrlQuery
 }) => Promise<{ [key: string]: any }>