Fix react@next and react@experimental tests (#26088)

vercel · Jun 14, 2021 · 1f09a78 · 1f09a78
1 parent 1ebf26a
commit 1f09a78
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/.github/workflows/test_react_next.yml b/.github/workflows/test_react_next.yml
@@ -31,6 +31,7 @@ jobs:
       NEXT_TELEMETRY_DISABLED: 1
       HEADLESS: true
       NEXT_PRIVATE_SKIP_SIZE_TESTS: true
+      NEXT_PRIVATE_REACT_ROOT: 1
     strategy:
       fail-fast: false
       matrix:

diff --git a/test/unit/link-warnings.test.js b/test/unit/link-warnings.test.js
@@ -3,11 +3,21 @@
  */
 import { act, render } from '@testing-library/react'
 import Link from 'next/link'
+import React from 'react'
+import { getPackageVersion } from 'next/dist/lib/get-package-version'
+import semver from 'next/dist/compiled/semver'
 
 describe('<Link/>', () => {
   let spy
-  beforeAll(() => {
+  let expectedErrors
+  beforeAll(async () => {
     spy = jest.spyOn(console, 'error').mockImplementation(() => {})
+
+    const reactVersion = await getPackageVersion({
+      cwd: __dirname,
+      name: 'react-dom',
+    })
+    expectedErrors = reactVersion && semver.gte(reactVersion, '18.0.0') ? 1 : 0
   })
 
   it('test link with unmount', () => {
@@ -16,15 +26,15 @@ describe('<Link/>', () => {
       unmount()
     })
 
-    expect(spy).not.toHaveBeenCalled()
+    expect(spy).toHaveBeenCalledTimes(expectedErrors)
   })
 
   it('test link without unmount', () => {
     act(() => {
       render(<Link href="/">hello</Link>)
     })
 
-    expect(spy).not.toHaveBeenCalled()
+    expect(spy).toHaveBeenCalledTimes(expectedErrors)
   })
 
   afterAll(() => {