Skip to content

Commit

Permalink
fix: Check if the GET comments response was ok, otherwise throw (#62041)
Browse files Browse the repository at this point in the history
Fixes #61941 example blog-with-comment.

The root issue is that the SWR fetcher does not check the `ok` status of the response, and that way we end up putting the error message object into the SWR data. And then `.map` is invoked in the object.

Since this is a learning kind of example, I think perhaps the presented change is just about enough to understand what's going on. Whether or not the people using the example want to gain access to the message from the server is up to them.
  • Loading branch information
icyJoseph committed Feb 14, 2024
1 parent 7744cc9 commit 6fb3993
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion examples/blog-with-comment/hooks/useComment.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,14 @@ import React, { useState } from "react";
import useSWR from "swr";
import { useAuth0 } from "@auth0/auth0-react";

const fetcher = (url) => fetch(url).then((res) => res.json());
const fetcher = (url) =>
fetch(url).then((res) => {
if (res.ok) {
return res.json();
}

throw new Error(`${res.status} ${res.statusText} while fetching: ${url}`);
});

export default function useComments() {
const { getAccessTokenSilently } = useAuth0();
Expand Down

0 comments on commit 6fb3993

Please sign in to comment.