Fix flaky full reload hmr tests

vercel · Sep 22, 2022 · 7974385 · 7974385
1 parent cc1e35d
commit 7974385
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/test/development/basic/hmr.test.ts b/test/development/basic/hmr.test.ts
@@ -793,13 +793,14 @@ describe('basic HMR', () => {
       )
       const newFileContent = currentFileContent.replace(
         '<p>hello world</p>',
-        '<p>hello world!!!</p>'
+        '<p id="updated">hello world!!!</p>'
       )
       await next.patchFile(
         './pages/hmr/anonymous-page-function.js',
         newFileContent
       )
-      await check(() => browser.elementByCss('p').text(), 'hello world!!!')
+
+      await browser.waitForElementByCss('#updated')
 
       // CLI warning and stacktrace
       expect(next.cliOutput.slice(start)).toContain(
@@ -834,9 +835,13 @@ describe('basic HMR', () => {
       const currentFileContent = await next.readFile(
         './pages/hmr/runtime-error.js'
       )
-      const newFileContent = currentFileContent.replace('whoops', '"whoops"')
+      const newFileContent = currentFileContent.replace(
+        'whoops',
+        '<p id="updated">whoops</p>'
+      )
       await next.patchFile('./pages/hmr/runtime-error.js', newFileContent)
-      await check(() => browser.elementByCss('body').text(), 'whoops')
+
+      await browser.waitForElementByCss('#updated')
 
       // CLI warning and stacktrace
       expect(next.cliOutput.slice(start)).toContain(