Is throwing an unnecessary error when getStaticProps & getServerSideProps are undefined

[aralroca]

Bug report

Describe the bug

When getStaticProps and getServerSideProps exist both as an export, is throwing an error.

You can not use getStaticProps with getServerSideProps. To use SSG, please remove getServerSideProps

Looks OK, however, IMO it should throw this error only when both are functions. With this, it will be possible to use conditional exports.

export let getStaticProps
export let getServerSideProps

if(process.env.SSG) {
  getStaticProps = loadData
} else { 
  getServerSideProps = loadData
}

To Reproduce

export const getStaticProps = undefined
export const getServerSideProps = undefined

Expected behavior

With this:

export const getStaticProps = undefined
export const getServerSideProps = async ctx => ({ props: { itWorks: false } })

I expect that getServerSideProps is executed because getStaticProps is not defined.

With this:

export const getStaticProps = async ctx => ({ props: { itWorks: false } })
export const getServerSideProps = undefined

I expect that getStaticProps is executed because getServerSideProps is not defined.

[Timer]

This behavior will not / should not work by design:

export let getStaticProps
export let getServerSideProps

if(process.env.SSG) {
  getStaticProps = loadData
} else { 
  getServerSideProps = loadData
}

You must export a function.

If the above works when you're not mixing the two, we need to issue a patch release to disallow such behavior.

[aralroca]

Ok @Timer ! But why this restriction instead of just ignore when they aren't functions?

[timneutkens]

Because getStaticProps en getServerSideProps are tree shaken from browser bundles and what you're trying to do (dynamic assignment) makes it impossible to tree shake it.

[aralroca]

Ok. In that case, it makes sense to me! Thanks to clarifying this @timneutkens

[felipenmoura]

Is there a way to use them both together?
I mean...my first thought was to use static props for some info (like version, port, path, envType, etc) and serverside props to api values.

[timneutkens]

Going to close this issue as it's using getStaticProps/getServerSideProps in an unsupported way.

@felipenmoura there are some feature requests for a behavior like that but getServerSideProps and getStaticProps are two different methods intentionally, they enable completely different behaviors.

[balazsorban44]

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.