fetchNextData does not support dynamic SSG routes with mismatching href and as
#14668
Assignees
Milestone
Comments
kodiakhq bot
pushed a commit
that referenced
this issue
Jun 29, 2020
This updates `fetchNextData` to re-use the `getDataHref` function from `page-loader` which has more verbose handling to ensure the correct `/_next/data` URL is built. Re-using this logic ensures the `/_next/data` URL can still be built even when a mismatching `href` and `as` value is provided to `next/link`. This also fixes a case in `getDataHref` where optional values that weren't provided would fail to build the data href since the check requiring the param be present while interpolating the route values hasn't been updated to allow missing params for optional values. An additional test case has been added to the prerender suite to ensure the `/_next/data` URL is built correctly when mismatching `href` and `as` values are provided x-ref: #14536 x-ref: #9081 (reply in thread) Closes: #14668
rokinsky
pushed a commit
to rokinsky/next.js
that referenced
this issue
Jul 11, 2020
This updates `fetchNextData` to re-use the `getDataHref` function from `page-loader` which has more verbose handling to ensure the correct `/_next/data` URL is built. Re-using this logic ensures the `/_next/data` URL can still be built even when a mismatching `href` and `as` value is provided to `next/link`. This also fixes a case in `getDataHref` where optional values that weren't provided would fail to build the data href since the check requiring the param be present while interpolating the route values hasn't been updated to allow missing params for optional values. An additional test case has been added to the prerender suite to ensure the `/_next/data` URL is built correctly when mismatching `href` and `as` values are provided x-ref: vercel#14536 x-ref: vercel#9081 (reply in thread) Closes: vercel#14668
|
This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Since
fetchNextDatadoesn't use the same/_next/databuilding logic asprefetchingwhen mismatchinghrefandasvalues are provided for a dynamic SSG route the page data will be able to be prefetched but not loaded on client-transition.The text was updated successfully, but these errors were encountered: