Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getStaticProps should not be able to fetch same-app API endpoints in development #15031

Closed
Timer opened this issue Jul 9, 2020 · 5 comments
Closed
Assignees
Labels
Developer Experience Issues related to Next.js logs, Error overlay, etc. good first issue Easy to fix issues, good for newcomers please verify canary The issue should be verified against next@canary. It will be closed after 30 days of inactivity
Milestone

Comments

@Timer
Copy link
Member

Timer commented Jul 9, 2020

Feature request

Next.js should make an attempt to block requests to same-app API endpoints (i.e. localhost) from getStaticProps during next dev since they'll fail when next build is run.

I'm not sure if this is even possible!

Describe the solution you'd like

For the following code, we should throw an error somehow:

export async function getStaticProps() {
  await fetch(`http://localhost:3000/api/journals`); // etc
  // ... rest
}
@Timer Timer added this to the backlog milestone Jul 9, 2020
@Timer Timer added the good first issue Easy to fix issues, good for newcomers label Jul 9, 2020
@timneutkens
Copy link
Member

We can do it using the new babel plugin warning system, however that will only get us as far as fetch() usage inside of getStaticProps/getServerSideProps and not if it's being done in another file. However that might be fine for now 👍

@Timer Timer changed the title getStaticProps should not be able to fetch API endpoints in development getStaticProps should not be able to fetch same-app API endpoints in development Jul 22, 2020
@geremora
Copy link

I'm having the same situation.

I want to make a request to the same-app API endpoints on the getStaticPaths.

In development works when I run both, next dev and next build at the same time.

@timneutkens timneutkens added the Developer Experience Issues related to Next.js logs, Error overlay, etc. label Nov 18, 2021
@jankaifer jankaifer self-assigned this Dec 1, 2022
@jankaifer jankaifer added the please verify canary The issue should be verified against next@canary. It will be closed after 30 days of inactivity label Dec 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

Please verify that your issue can be recreated with next@canary.

Why was this issue marked with the please verify canary label?

We noticed the provided reproduction was using an older version of Next.js, instead of canary.

The canary version of Next.js ships daily and includes all features and fixes that have not been released to the stable version yet. You can think of canary as a public beta. Some issues may already be fixed in the canary version, so please verify that your issue reproduces by running npm install next@canary and test it in your project, using your reproduction steps.

If the issue does not reproduce with the canary version, then it has already been fixed and this issue can be closed.

How can I quickly verify if my issue has been fixed in canary?

The safest way is to install next@canary in your project and test it, but you can also search through closed Next.js issues for duplicates or check the Next.js releases.

My issue has been open for a long time, why do I need to verify canary now?

Next.js does not backport bug fixes to older versions of Next.js. Instead, we are trying to introduce only a minimal amount of breaking changes between major releases.

What happens if I don't verify against the canary version of Next.js?

An issue with the please verify canary that receives no meaningful activity (e.g. new comments that acknowledge verification against canary) will be automatically closed and locked after 30 days.

If your issue has not been resolved in that time and it has been closed/locked, please open a new issue, with the required reproduction, using next@canary.

I did not open this issue, but it is relevant to me, what can I do to help?

Anyone experiencing the same issue is welcome to provide a minimal reproduction following the above steps. Furthermore, you can upvote the issue using the 👍 reaction on the topmost comment (please do not comment "I have the same issue" without repro steps). Then, we can sort issues by votes to prioritize.

I think my reproduction is good enough, why aren't you looking into it quicker?

We look into every Next.js issue and constantly monitor open issues for new comments.

However, sometimes we might miss one or two due to the popularity/high traffic of the repository. We apologize, and kindly ask you to refrain from tagging core maintainers, as that will usually not result in increased priority.

Upvoting issues to show your interest will help us prioritize and address them as quickly as possible. That said, every issue is important to us, and if an issue gets closed by accident, we encourage you to open a new one linking to the old issue and we will look into it.

Useful Resources

@balazsorban44
Copy link
Member

This issue has been automatically closed because it wasn't verified against next@canary. If you think it was closed by accident, please leave a comment. If you are running into a similar issue, please open a new issue with a reproduction. Thank you.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2023

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Developer Experience Issues related to Next.js logs, Error overlay, etc. good first issue Easy to fix issues, good for newcomers please verify canary The issue should be verified against next@canary. It will be closed after 30 days of inactivity
Projects
None yet
Development

No branches or pull requests

5 participants