Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify a different build directory instead of .next #1513

Closed
abstractpoint opened this issue Mar 26, 2017 · 9 comments
Closed

Specify a different build directory instead of .next #1513

abstractpoint opened this issue Mar 26, 2017 · 9 comments

Comments

@abstractpoint
Copy link

I am trying to deploy next to Firebase functions, and It looks like the .next build directory is ignored by firebase cli.

Firebase cli seems to ignore all hidden files, so I want to use a differently named directory.

The directory seems to be hardcoded in 3 places:
/dist/bin/next-start
/dist/server/build/clean.js
/dist/server/build/index.js

@alexnewmannn
Copy link
Contributor

Would this be something that would like to be added via config? maybe next.config? If so, I can take a look at this?

@arunoda
Copy link
Contributor

arunoda commented Mar 28, 2017

Yep. That's the api we could do it.

@alexnewmannn
Copy link
Contributor

Im having a look at this now. Is there any standards or practices against config? For sake of testing it out im running the following in next.config:

module.exports = {
  options: {
    dest: 'dist'
  }
}

Have any other ideas?

@arunoda
Copy link
Contributor

arunoda commented Mar 28, 2017

I'd like to see it like this:

module.exports = {
  options: {
    dist: '.next'
  }
}

@alexnewmannn
Copy link
Contributor

no worries, got some of it done last night. WIll continue with it tonight 👍

@alexnewmannn
Copy link
Contributor

Pr incoming for this; just updating documentation.

@alexnewmannn
Copy link
Contributor

@abstractpoint @arunoda #1599 Opened a PR for it; let me know if any issues.
Cheers

arunoda pushed a commit that referenced this issue Apr 6, 2017
* Update references to `.next`

* Remove console logs and extraneous semi colons

* Remove lint errors

* Update references to .next and update docs

* Update options from nested to flat with `distDir`

* Add integration tests, and update `.gitignore`

* Rename integration folder to dist-dir to match standards
@alexnewmannn
Copy link
Contributor

@abstractpoint this is now merged if you want to try on latest master.

@abstractpoint
Copy link
Author

@alexnewmannn Working great, super useful. Thank you for putting in the time! (Still battling with Firebase being too slow running next, but that's not really related)

@lock lock bot locked as resolved and limited conversation to collaborators May 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants