Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Static Optimization Indicator to false #18275

Closed
ericelliott opened this issue Oct 26, 2020 · 12 comments · Fixed by #18629
Closed

Default Static Optimization Indicator to false #18275

ericelliott opened this issue Oct 26, 2020 · 12 comments · Fixed by #18629
Labels
good first issue Easy to fix issues, good for newcomers
Milestone

Comments

@ericelliott
Copy link

Feature request

For validation of this feature request see almost all the comments on "How to remove the clickable label "Prerendered Page" and loading Icon ? #7945".

The automatic Static Optimization Indicator is providing important information, but that information is being handled in an undesirable manner for DX and dev team collaboration. In many cases, the indication can get in the way of the app's UI during development, creating a frustrating developer experience for Next users.

It also creates a frustrating experience for designers and other non-developer stakeholders, who don't immediately understand that the icon is only visible in development, and think the app is somehow broken or poorly designed.

It creates a frustrating experience for new feature demos, as well.

I understand that you can opt-out, but you shouldn't have to opt-out of obtrusive features, you should have to opt-in to them.

Describe the solution you'd like

The situation that the indicator is indicating should be the default situation for most pages in a Next site. The indicator is intrusively shouting at us "EVERYTHING IS NORMAL AND OK!"

ummm... thanks? Why not warn me when it's abnormal and NOT OK, instead? And why not put the warning in the developer console instead of on the UI screen so we don't give the designers and other non-dev contributors a heart attack?

Describe alternatives you've considered

Stuff like this would be great in a DevTools extension similar to React or Redux DevTools. Make all the alarming indicators you want somewhere other than the app UI screen.

@janhoogeveen
Copy link

Afaik you can disable the icon in the config with some kind of hidden flag. Look at the next-server package defaults to see which one you need to set to false.

@ericelliott
Copy link
Author

@janhoogeveen Yes. Hence:

I understand that you can opt-out, but you shouldn't have to opt-out of obtrusive features, you should have to opt-in to them.

@Timer Timer added this to the iteration 11 milestone Oct 29, 2020
@Timer
Copy link
Member

Timer commented Oct 29, 2020

This feature has served its purpose to teach people about Next.js' SSG capabilities (even automatic)! We can remove it now.

Would you like to send a PR removing all the related code?

@ericelliott
Copy link
Author

@Timer

I would love to. Unfortunately, I don't have the time. 😞

@Timer
Copy link
Member

Timer commented Oct 30, 2020

We'll take care of it!

@Timer Timer added the point: 2 label Oct 30, 2020
@Timer Timer modified the milestones: iteration 11, iteration 12 Oct 30, 2020
@Timer Timer added the good first issue Easy to fix issues, good for newcomers label Oct 30, 2020
@cascandaliato
Copy link
Contributor

Is this still up for grabs? I've recently submitted a PR in the same area (#18261) so it should not be too difficult for me to remove the indicator entirely.

@Timer
Copy link
Member

Timer commented Nov 1, 2020

Go ahead and take it!

@lachlanjc
Copy link
Contributor

Sounds cool to remove, & I know the icon was just for demonstrating static pages, but I always thought the visual similarity to the Vercel logo is one of the smartest open source marketing moves I can remember—right when the framework is doing something brilliant for you & unobtrusively reminding you about it, it reminds you of Vercel. Loved that thing.

@Timer
Copy link
Member

Timer commented Nov 1, 2020

@lachlanjc there's still the Vercel logo during a Fast Refresh occurring!

@BhavyaCodes
Copy link

I've started to learn nextjs since yesterday and I noticed I dont see the battery icon. How do I enable it lol?

@cafecafe
Copy link

Is there a way to turn it back on (perhaps, the same way it could have been turned off before?)

The icon is still beneficial to those who learn NextJS.

@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Easy to fix issues, good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants