Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

12.0.4 breaks metatags #31593

Closed
jahirfiquitiva opened this issue Nov 18, 2021 · 4 comments · Fixed by #31628
Closed

12.0.4 breaks metatags #31593

jahirfiquitiva opened this issue Nov 18, 2021 · 4 comments · Fixed by #31628
Labels
bug Issue was opened via the bug report template.

Comments

@jahirfiquitiva
Copy link

What version of Next.js are you using?

12.0.4

What version of Node.js are you using?

14.17.4

What browser are you using?

Brave (Chromium)

What operating system are you using?

macOS

How are you deploying your application?

Vercel (next build)

Describe the Bug

After updating NextJS to v 12.0.4, my dynamic metatags have stopped working.

This is how my metatags look after updating:
Shot 2021-11-18 at 18-27-36@2x

Expected Behavior

My website metatags should look like this:
Shot 2021-11-18 at 18-26-55@2x

To Reproduce

Here's my repository with the last working commit: jahirfiquitiva/jahir.dev@90bdc2e

This is the same repository with the commit that broke metatags: jahirfiquitiva/jahir.dev@2478454

I am using metatags.io to preview the sites metatags.

I can confirm it was due to NextJS 12.0.4, because this commmit reverting to 12.0.3 makes metatags work as expected again:
@jahirfiquitiva jahirfiquitiva added the bug Issue was opened via the bug report template. label Nov 18, 2021
@jahirfiquitiva
Copy link
Author

Another thing I noticed that got broken is @pacocoursey 's next-themes ... on first load, the theme flashes exist

@imranbarbhuiya
Copy link
Contributor

imranbarbhuiya commented Nov 19, 2021 •
edited

I just tested my site in both https://metatags.io and https://cards-dev.twitter.com/validator

https://metatags.io isn't showing anything while https://cards-dev.twitter.com/validator is showing only title and description, but image isn't loading.

nextjs v12.0.4
node 17.1.0

@ijjk ijjk mentioned this issue Nov 19, 2021
Merged
3 tasks
@kodiakhq kodiakhq bot closed this as completed in #31628 Nov 19, 2021
kodiakhq bot pushed a commit that referenced this issue Nov 19, 2021
@ijjk
Fix non-concurrent function _document (#31628)
e8ca334 
This ensures functional `_document` is rendered correctly when not using concurrent mode. 

## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

Fixes: #31593
x-ref: #30156
@ijjk
Copy link
Member

ijjk commented Nov 19, 2021

Hi, this has been updated in v12.0.5-canary.5, please update and give it a try!

@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
natew pushed a commit to natew/next.js that referenced this issue Feb 16, 2022
@ijjk @natew
Fix non-concurrent function _document (vercel#31628)
95ed8a6 
This ensures functional `_document` is rendered correctly when not using concurrent mode. 

## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

Fixes: vercel#31593
x-ref: vercel#30156
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Issue was opened via the bug report template.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix non-concurrent function _document ijjk/next.js
4 participants
@jahirfiquitiva @balazsorban44 @ijjk @imranbarbhuiya