Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

with-aws-amplify-typescript uses legacy AmplifyAuthenticator #35222

Closed
swalker326 opened this issue Mar 10, 2022 · 3 comments · Fixed by #41815
Closed

with-aws-amplify-typescript uses legacy AmplifyAuthenticator #35222

swalker326 opened this issue Mar 10, 2022 · 3 comments · Fixed by #41815
Labels
examples Issue/PR related to examples good first issue Easy to fix issues, good for newcomers

Comments

@swalker326
Copy link

Describe the feature you'd like to request

Currently uses AmplifyAuthenticator which is legacy. Also using an older verison of @aws-amplify/ui-react & aws-amplify

Describe the solution you'd like

Should be using the new Authenticator componet

Describe alternatives you've considered

Keep using the old one until is deprecated

@ELBEQQAL94
Copy link

This issue is still open I would like to contribute?

@sifanjoraboris
Copy link

Helping

@kodiakhq kodiakhq bot closed this as completed in #41815 Oct 26, 2022
kodiakhq bot pushed a commit that referenced this issue Oct 26, 2022
## Documentation / Examples

- [x] Make sure the linting passes by running `pnpm lint`
- [x] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
- [x] Updated `aws-amplify` and `@aws-amplify/ui-react` to latest versions
- [x] Updated `README.md` with latest command line prompts from `amplify` and `@aws-amplify/cli`
- [x] Added latest versions of `typescript`, `@types/react`, `@types/react-dom`, and `@types/node`
- [x] Deleted all files in `with-aws-amplify-typescript` and updated `README.md` to indicate that it has moved to `with-aws-amplify`

## Previous work:
- Closes: #35222
- Continues from PR: #35318



Co-authored-by: Balázs Orbán <18369201+balazsorban44@users.noreply.github.com>
@github-actions
Copy link
Contributor

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples good first issue Easy to fix issues, good for newcomers
Projects
None yet
4 participants