Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next build on canary using full path in transpiled require statements #3533

Closed
1 task done
kylealwyn opened this issue Jan 4, 2018 · 3 comments
Closed
1 task done
Assignees

Comments

@kylealwyn
Copy link

kylealwyn commented Jan 4, 2018

  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

next build does not include absolute path to node module

Current Behavior

next build includes absolute path in transpiled require path

Steps to Reproduce (for bugs)

Correct

yarn add next@4.2.0
next build

# Transpiled output
var _extends2 = require('babel-runtime/helpers/extends');

Incorrect

yarn add next@canary
next build

# Transpiled output
var _extends2 = require('/Users/kyle/projects/test/node_modules/babel-runtime/helpers/extends');

Context

Unable to deploy to lambda using up due to up building locally and uploading zip file to s3 rendering absolute paths invalid

Your Environment

Tech Version
next canary
node 8.9.0
OS macos 10.13.2
@kylealwyn kylealwyn changed the title next build on canary using full path in transpiled requires next build on canary using full path in transpiled require statements Jan 11, 2018
@mrtnzlml
Copy link

mrtnzlml commented Feb 5, 2018

Same problem - see ^^ postmortem. Also serverless environment deployed from Travis-CI.

@timneutkens timneutkens self-assigned this Feb 5, 2018
@juancampa
Copy link
Contributor

@timneutkens
Copy link
Member

timneutkens commented Feb 6, 2018

Created a pull request 🙏 I had actually already fixed the babel-runtime issue. The pages issue is a new one 👍

@lock lock bot locked as resolved and limited conversation to collaborators Feb 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants