Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Found invalid GitHub URL -- Again #39642

Closed
1 task done
pdini opened this issue Aug 16, 2022 · 4 comments · Fixed by #39665
Closed
1 task done

Found invalid GitHub URL -- Again #39642

pdini opened this issue Aug 16, 2022 · 4 comments · Fixed by #39665
Labels
bug Issue was opened via the bug report template.

Comments

@pdini
Copy link

pdini commented Aug 16, 2022

Verify canary release

  • I verified that the issue exists in the latest Next.js canary release

Provide environment information

Operating System:
  Platform: darwin
  Arch: arm64
  Version: Darwin Kernel Version 21.6.0: Sat Jun 18 17:07:22 PDT 2022; root:xnu-8020.140.41~1/RELEASE_ARM64_T6000
Binaries:
  Node: 18.7.0
  npm: 8.15.0
  Yarn: 1.22.18
  pnpm: N/A
Relevant packages:
  next: 12.2.6-canary.0
  eslint-config-next: N/A
  react: 18.2.0
  react-dom: 18.2.0

What browser are you using? (if relevant)

No response

How are you deploying your application? (if relevant)

Vercel

Describe the Bug

The command
npx create-next-app -e https://github.com/0xdevnet/juno-dapp-starter/ my-juno-dapp
returns
Found invalid GitHub URL: "https://github.com/0xdevnet/juno-dapp-starter/". Please fix the URL and try again.
I tried also the url https://github.com/0xkdavid/juno-dapp-starter/ suggested in the Readme with the same result.

This problem has come up before (here and here) and they were described as resolved.

Expected Behavior

I expect the installation to proceed and the "my-juno-dapp" folder to be created.

Link to reproduction

#34073

To Reproduce

Type npx create-next-app -e https://github.com/0xdevnet/juno-dapp-starter/ my-juno-dapp in the CLI

@pdini pdini added the bug Issue was opened via the bug report template. label Aug 16, 2022
@SukkaW
Copy link
Contributor

SukkaW commented Aug 16, 2022

The issue is caused by the trailing slash of the URL. Remove the trailing slash the URL will work:

npx create-next-app -e https://github.com/0xdevnet/juno-dapp-starter my-juno-dapp

@pdini
Copy link
Author

pdini commented Aug 16, 2022

Thanks that worked!

@SukkaW
Copy link
Contributor

SukkaW commented Aug 16, 2022

I have created a PR (#39665) to let create-next-app be able to handle GitHub URL with a trailing slash.

kodiakhq bot pushed a commit that referenced this issue Aug 17, 2022
## Bug

- [x] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

The PR fixes #39642, by supporting GitHub repo URLs with a trailing slash while without branch and path.
@github-actions
Copy link
Contributor

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue was opened via the bug report template.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants