Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EXAMPLE] Add example NextJS with Radix-UI #40072

Closed
rntvicente opened this issue Aug 30, 2022 · 10 comments · Fixed by #41169
Closed

[EXAMPLE] Add example NextJS with Radix-UI #40072

rntvicente opened this issue Aug 30, 2022 · 10 comments · Fixed by #41169
Labels
examples Issue/PR related to examples good first issue Easy to fix issues, good for newcomers

Comments

@rntvicente
Copy link

Describe the feature you'd like to request

Please provide an example of how to use Radix-UI with NextJS.

Describe the solution you'd like

Provide Radix-UI with NextJS

Describe alternatives you've considered

.
@balazsorban44 balazsorban44 added good first issue Easy to fix issues, good for newcomers examples Issue/PR related to examples and removed template: story labels Sep 1, 2022
@chaiwattsw
Copy link
Contributor

I will take this issue.

@rntvicente
Copy link
Author

I will take this issue.

I want to help, what can I do?

@dusklight00
Copy link

dusklight00 commented Sep 6, 2022 •
edited

@rntvicente Can I contribute to this issue as well? I would start researching into it, and come up with a good example code.

@chaiwattsw
Copy link
Contributor

Not sure if we need to provide CSS-IN-JS (which will include dependency like Stitches) or just a CSS (inline or className) approach? @balazsorban44

@chaiwattsw
Copy link
Contributor

@rntvicente currently I'm setup example folder, not sure what can you do right now, maybe you can give a comment or feedback after I push my PR.

@rntvicente
Copy link
Author

Not sure if we need to provide CSS-IN-JS (which will include dependency like Stitches) or just a CSS (inline or className) approach? @balazsorban44

Hi @chaiwattsw , perfect question. I think two example with CSS-in-JS and CSS inline. What do you think?

@chaiwattsw
Copy link
Contributor

In my opinion, not to include both examples. I would prefer CSS-IN-JS only

@rntvicente
Copy link
Author

In my opinion, not to include both examples. I would prefer CSS-IN-JS only

I agree, we can do two examples with stitchesjs and one with CSS-In-JS. What do you think?

@rohan9024
Copy link

Is anyone working on this issue?

@pedro757 pedro757 mentioned this issue Oct 4, 2022
Merged
2 tasks
@kodiakhq kodiakhq bot closed this as completed in #41169 Oct 5, 2022
kodiakhq bot pushed a commit that referenced this issue Oct 5, 2022
@pedro757 @balazsorban44
chore(examples): add Radix UI example (#41169)
6e17169 
fixes #40072 

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm lint`
- [x] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)


Co-authored-by: Balázs Orbán <18369201+balazsorban44@users.noreply.github.com>
BowlingX pushed a commit to BowlingX/next.js that referenced this issue Oct 5, 2022
@pedro757 @balazsorban44 @BowlingX
chore(examples): add Radix UI example (vercel#41169)
213dd22 
fixes vercel#40072 

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm lint`
- [x] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)


Co-authored-by: Balázs Orbán <18369201+balazsorban44@users.noreply.github.com>
Kikobeats pushed a commit to Kikobeats/next.js that referenced this issue Oct 24, 2022
@pedro757 @balazsorban44 @Kikobeats
chore(examples): add Radix UI example (vercel#41169)
a0f112f 
fixes vercel#40072 

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm lint`
- [x] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)


Co-authored-by: Balázs Orbán <18369201+balazsorban44@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2022

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
examples Issue/PR related to examples good first issue Easy to fix issues, good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(examples): add Radix UI example pedro757/next.js
5 participants
@balazsorban44 @rntvicente @chaiwattsw @rohan9024 @dusklight00