Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

does not compile src/app folder in dev #41456

Closed
1 task done
sviridoff opened this issue Oct 16, 2022 · 2 comments · Fixed by #41458
Closed
1 task done

does not compile src/app folder in dev #41456

sviridoff opened this issue Oct 16, 2022 · 2 comments · Fixed by #41458
Labels
bug Issue was opened via the bug report template.

Comments

@sviridoff
Copy link
Contributor

Verify canary release

  • I verified that the issue exists in the latest Next.js canary release

Provide environment information

Operating System:
  Platform: linux
  Arch: x64
  Version: #42-Ubuntu SMP Thu May 19 05:03:08 UTC 2022
Binaries:
  Node: 16.17.1
  npm: 8.15.0
  Yarn: 3.2.4
  pnpm: N/A
Relevant packages:
  next: 12.3.2-canary.29
  eslint-config-next: N/A
  react: 0.0.0-experimental-3b814327e-20221014
  react-dom: 0.0.0-experimental-3b814327e-20221014

What browser are you using? (if relevant)

No response

How are you deploying your application? (if relevant)

next dev

Describe the Bug

When you have set experimental appDir flag and running next dev script, the components inside src/app path are not compiled.

Expected Behavior

We expect the components inside app folder be compiled

Link to reproduction

https://github.com/sviridoff/next_src_app_bug

To Reproduce

git clone https://github.com/sviridoff/next_src_app_bug
cd next_src_app_bug
yarn
yarn dev
go to localhost:3000/home you will see 404
@sviridoff sviridoff added the bug Issue was opened via the bug report template. label Oct 16, 2022
@sviridoff sviridoff mentioned this issue Oct 16, 2022
Merged
11 tasks
@balazsorban44
Copy link
Member

This is being actively worked on, thanks for the feedback!

ijjk added a commit that referenced this issue Oct 17, 2022
@sviridoff @huozhi @ijjk
fix(41456): check src/app folder too in getHasAppDir (#41458)
f5cb7bd 
fixes #41456

When we check if app folder exists, check for src/app path too

## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added
- [ ] Errors have a helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the
feature request has been accepted for implementation before opening a
PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have a helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm lint`
- [ ] The "examples guidelines" are followed from [our contributing
doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)

Co-authored-by: Jiachi Liu <inbox@huozhi.im>
Co-authored-by: JJ Kasper <jj@jjsweb.site>
Kikobeats pushed a commit to Kikobeats/next.js that referenced this issue Oct 24, 2022
@sviridoff @huozhi
@ijjk @Kikobeats
fix(41456): check src/app folder too in getHasAppDir (vercel#41458)
e58314b 
fixes vercel#41456

When we check if app folder exists, check for src/app path too

## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added
- [ ] Errors have a helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the
feature request has been accepted for implementation before opening a
PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have a helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm lint`
- [ ] The "examples guidelines" are followed from [our contributing
doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)

Co-authored-by: Jiachi Liu <inbox@huozhi.im>
Co-authored-by: JJ Kasper <jj@jjsweb.site>
@github-actions
Copy link
Contributor

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Issue was opened via the bug report template.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(41456): check src/app folder too in getHasAppDir sviridoff/next.js
2 participants
@sviridoff @balazsorban44