Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(test-utils): correct --turbo error overlay lookup #46901

Merged
merged 2 commits into from Mar 27, 2023
Merged

test(test-utils): correct --turbo error overlay lookup #46901

merged 2 commits into from Mar 27, 2023

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented Mar 7, 2023

Fixing a bug

Minor fix for #46589, forgot to wrap in evaluate in result fail to ask to browser to lookup overlay in --turbo tests.

@ijjk ijjk added area: tests created-by: Turbopack team PRs by the turbopack team labels Mar 27, 2023
ijjk
ijjk approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally this divergence is removed when we dedupe the overlays although seems fine to handle for now

@ijjk ijjk merged commit 73491e1 into vercel:canary Mar 27, 2023
92 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@feedthejim feedthejim Awaiting requested review from feedthejim feedthejim is a code owner

Assignees
No one assigned
Labels
created-by: Turbopack team PRs by the turbopack team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kwonoj @ijjk