Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Support dynamic routes for social images and icons" (#47416 #47416

Merged
merged 1 commit into from Mar 22, 2023
Merged

Revert "Support dynamic routes for social images and icons" (#47416 #47416

merged 1 commit into from Mar 22, 2023

Conversation

styfle
Copy link
Member

@styfle styfle commented Mar 22, 2023 •
edited

Reverts #47372

Error occurred prerendering page "/apple-icon". Read more: https://nextjs.org/docs/messages/prerender-error
Error: The `ImageResponse` API is not supported in this runtime, use the `unstable_createNodejsStream` API instead or switch to the Vercel Edge Runtime.
    at new ImageResponse (/tmp/next-install-db63e2a2f25e9feda48affa69456fcbdde8d89bf94645e42abd2aa522224f432/.next/server/chunks/558.js:26416:19)
    at appleIcon (/tmp/next-install-db63e2a2f25e9feda48affa69456fcbdde8d89bf94645e42abd2aa522224f432/.next/server/app/apple-icon/route.js:127:12)

https://github.com/vercel/next.js/actions/runs/4490842502/jobs/7899302486#step:6:305

@linear
Copy link

linear bot commented Mar 22, 2023

Issue reopened: NEXT-264 Implement dynamic file-based icons and apple-icons

@linear
Copy link

linear bot commented Mar 22, 2023

Issue reopened: NEXT-266 Implement dynamic file-based opengraph and twitter media

@shuding shuding changed the title Revert "Support dynamic routes for social images and icons" Revert "Support dynamic routes for social images and icons" (#47416 Mar 22, 2023
@shuding shuding merged commit 7060b8c into canary Mar 22, 2023
25 of 28 checks passed
@shuding shuding deleted the revert-47372-metadata/og-image-route branch March 22, 2023 19:24
@huozhi huozhi mentioned this pull request Mar 22, 2023
Merged
kodiakhq bot pushed a commit that referenced this pull request Mar 23, 2023
@huozhi
Support dynamic routes for social images and icons (#47425)
9150620 
Redo #47372 , basically revert #47416 and upgrade og (vercel/og#60)

Closes NEXT-264
Closes NEXT-266
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shuding shuding shuding approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@feedthejim feedthejim Awaiting requested review from feedthejim feedthejim is a code owner

Assignees
No one assigned
Labels
area: tests created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@styfle @shuding @ijjk